make /task-new always chain into the resolver #28

Merged
jerome merged 1 commit from feat/always-implement into main 2026-08-09 18:45:17 +03:00
Collaborator

Goal: /task-new never ends with a drafted PR and no resolver pass.

Value: med
Effort: 30m


Why

Step 11 made "drafted, not implemented" a reachable end state twice over:
it printed the PR and asked "want to adjust anything?" (an invitation to
stop), and it skipped the /task-implement chain entirely in
improve-existing mode. Runs kept ending at the spec.

The pipeline's only legal stop is the resolver's code-complete point --
before the test loop and before the first /task-review.
/task-orchestrate already auto-runs review + fix (cap 3 passes) and
stops only before merge, so nothing downstream needed changing.


Steps

  • task-new frontmatter + Overview: state the hand-off as unconditional.
  • Rewrite Step 11 as "Show, then always hand off" -- printing is a status
    line, not a gate; both modes chain; the only skip is running as a
    subagent of /task-implement (loop guard).
  • Name the earliest legal stop in Step 11 (resolver code-complete) and
    point at /task-orchestrate for the auto-run review + fix loop.
  • Add three Common-mistakes rows covering the removed exits.
  • task-implement Step 1f: the picker's "draft a new task PR" option now
    says spawn, re-probe, resume at Step 2 -- never end the pass at
    "drafted".

Notes

Prose-only change across two SKILL.md files; no scripts touched, so
there is nothing for tests/ to cover.

The subagent-of-/task-implement skip is kept deliberately -- without it
the chain loops implement -> new -> implement.

/task-orchestrate was read and left alone: Step 4 already loops
fix-on-branch on concerns/blocking without prompting, and Step 5 is
the intended merge gate.

**Goal:** `/task-new` never ends with a drafted PR and no resolver pass. **Value:** med **Effort:** 30m --- ## Why Step 11 made "drafted, not implemented" a reachable end state twice over: it printed the PR and asked "want to adjust anything?" (an invitation to stop), and it skipped the `/task-implement` chain entirely in improve-existing mode. Runs kept ending at the spec. The pipeline's only legal stop is the resolver's code-complete point -- before the test loop and before the first `/task-review`. `/task-orchestrate` already auto-runs review + fix (cap 3 passes) and stops only before merge, so nothing downstream needed changing. --- ## Steps - [x] `task-new` frontmatter + Overview: state the hand-off as unconditional. - [x] Rewrite Step 11 as "Show, then always hand off" -- printing is a status line, not a gate; both modes chain; the only skip is running as a subagent of `/task-implement` (loop guard). - [x] Name the earliest legal stop in Step 11 (resolver code-complete) and point at `/task-orchestrate` for the auto-run review + fix loop. - [x] Add three Common-mistakes rows covering the removed exits. - [x] `task-implement` Step 1f: the picker's "draft a new task PR" option now says spawn, re-probe, resume at Step 2 -- never end the pass at "drafted". --- ## Notes Prose-only change across two `SKILL.md` files; no scripts touched, so there is nothing for `tests/` to cover. The subagent-of-`/task-implement` skip is kept deliberately -- without it the chain loops `implement -> new -> implement`. `/task-orchestrate` was read and left alone: Step 4 already loops fix-on-branch on `concerns`/`blocking` without prompting, and Step 5 is the intended merge gate.
docs: make task-new always chain into the resolver
All checks were successful
gitleaks / gitleaks (pull_request) Successful in 4s
91c984376f
Draft-then-stop was a valid exit path: Step 11 gated the hand-off behind a
"want to adjust anything?" prompt and skipped it outright in improve-existing
mode. Make the chain unconditional -- the only skip is running as a subagent of
/task-implement (loop guard) -- and name the resolver's code-complete point as
the earliest legal stop.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jerome approved these changes 2026-08-09 18:45:13 +03:00
jerome merged commit 189ff211d1 into main 2026-08-09 18:45:17 +03:00
jerome deleted branch feat/always-implement 2026-08-09 18:45:17 +03:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
public/chiche-plugins!28
No description provided.