fix(task): default no-PR to /task-new; verify Goal efficacy in review #13

Merged
jerome merged 1 commit from orchestrate-new-entry into main 2026-06-30 19:25:29 +03:00
Collaborator

Goal

Fix two behavioural gaps in the task suite skills.

Why

  • task-orchestrate started at implement, not new. When no drafted PR
    matched the request, orchestrate's Step 1 prompt framed the resolve subagent
    as "resolve an existing PR's spec", biasing it past /task-implement's
    draft-new gate into a one-shot auto-draft straight to code -- skipping the
    /task-new brainstorm.
  • task-review checked Steps, not the fix. Review mapped PR-body Steps to
    the diff and ran lint/typecheck/test, but never confirmed the change actually
    resolves the PR's Goal, and ignored the smoke command the Toolchain
    block defines.

Steps

  • task-orchestrate + task-implement: make /task-new (brainstorm a full
    spec) the default no-PR entry; one-shot auto-draft is now opt-in (explicit
    one-shot ask only). Updated Step 1 subagent prompt, Quick Reference, Overview,
    When-to-Use, picker, and descriptions.
  • task-review: add Step 9 — efficacy check that runs the Toolchain
    smoke command as end-to-end proof the Goal is met (reasons from the diff +
    tests when none is declared). Add a 4th review question, an efficacy finding
    kind + smoke check, fold efficacy into the verdict (ok requires Goal met,
    unmet → blocking), renumber subsequent steps and all cross-refs, add a
    Common Mistakes bullet, update the description.

Notes

Docs-only changes to three SKILL.md files; no code. Design decisions confirmed
with the user: /task-new default + one-shot opt-in; efficacy = smoke run only
(no required regression test).

## Goal Fix two behavioural gaps in the `task` suite skills. ## Why - **task-orchestrate started at implement, not new.** When no drafted PR matched the request, orchestrate's Step 1 prompt framed the resolve subagent as "resolve an existing PR's spec", biasing it past `/task-implement`'s draft-new gate into a one-shot auto-draft straight to code -- skipping the `/task-new` brainstorm. - **task-review checked Steps, not the fix.** Review mapped PR-body Steps to the diff and ran lint/typecheck/test, but never confirmed the change actually resolves the PR's **Goal**, and ignored the `smoke` command the Toolchain block defines. ## Steps - [x] `task-orchestrate` + `task-implement`: make `/task-new` (brainstorm a full spec) the **default** no-PR entry; one-shot auto-draft is now opt-in (explicit one-shot ask only). Updated Step 1 subagent prompt, Quick Reference, Overview, When-to-Use, picker, and descriptions. - [x] `task-review`: add **Step 9 — efficacy check** that runs the Toolchain `smoke` command as end-to-end proof the Goal is met (reasons from the diff + tests when none is declared). Add a 4th review question, an `efficacy` finding kind + `smoke` check, fold efficacy into the verdict (`ok` requires Goal met, unmet → `blocking`), renumber subsequent steps and all cross-refs, add a Common Mistakes bullet, update the description. ## Notes Docs-only changes to three `SKILL.md` files; no code. Design decisions confirmed with the user: `/task-new` default + one-shot opt-in; efficacy = smoke run only (no required regression test).
fix(task): default no-PR to /task-new; verify Goal efficacy in review
All checks were successful
gitleaks / gitleaks (pull_request) Successful in 3s
f486bab404
task-orchestrate delegated resolve to /task-implement with a prompt
framed as "resolve an existing PR's spec", biasing the subagent past
the draft-new gate. Make /task-new the default no-PR entry across
task-orchestrate and task-implement; one-shot auto-draft is now
opt-in (explicit one-shot ask only).

task-review checked Steps->diff but never confirmed the change
resolves the PR's Goal. Add Step 9 efficacy check (runs the Toolchain
`smoke` command as end-to-end proof; reasons from the diff when none
declared), a 4th review question, an `efficacy` finding kind, and fold
it into the verdict. Renumber subsequent steps + cross-refs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jerome approved these changes 2026-06-30 19:25:26 +03:00
jerome merged commit 4110dddb48 into main 2026-06-30 19:25:29 +03:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
public/chiche-plugins!13
No description provided.